Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused Blaze templates after message rewrite #28025

Merged
merged 33 commits into from Feb 14, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 13, 2023

body -> refactor

emojiPicker -> refactor

authorize -> refactor
oauth404 -> refactor

CodeMirror -> refactor

inputAutocomplete
_autocompleteContainer ->inputAutocomplete
_noMatch -> inputAutocomplete
loading -> inputAutocomplete
roomSearch -> inputAutocomplete -> roomPicker setting
    roomSearchEmpty


username -> refactor
customFieldsForm -> username, refactor

messagePopupSlashCommandPreview -> refactor

RocketSearch -> globalSearch remove or refactor
    DefaultSuggestionItemTemplate
    DefaultSearchResultTemplate
    ExternalFrameContainer

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #28025 (20f9258) into develop (88f7024) will increase coverage by 1.25%.
The diff coverage is 51.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28025      +/-   ##
===========================================
+ Coverage    42.24%   43.49%   +1.25%     
===========================================
  Files          812      795      -17     
  Lines        16052    15371     -681     
  Branches      2072     2066       -6     
===========================================
- Hits          6781     6686      -95     
+ Misses        8991     8401     -590     
- Partials       280      284       +4     
Flag Coverage Δ
e2e 43.49% <51.61%> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 14, 2023 21:48
@ggazzo ggazzo requested a review from a team as a code owner February 14, 2023 21:48
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the context for all the changes, but codewise lgtm.

@ggazzo ggazzo merged commit 69eab92 into develop Feb 14, 2023
@ggazzo ggazzo deleted the chore/templates branch February 14, 2023 22:19
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants