Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unused Blaze templates after message rewrite #28025

Merged
merged 33 commits into from
Feb 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
b0610be
remove popupList
ggazzo Feb 13, 2023
b63d5c9
oembed
ggazzo Feb 13, 2023
7a47e2c
messageThread
ggazzo Feb 13, 2023
2a40ac0
Avatar
ggazzo Feb 13, 2023
ebdc9ed
lazy-load
ggazzo Feb 13, 2023
2242dd2
remove useless popup calls
ggazzo Feb 13, 2023
bf5af9c
remove message templates
ggazzo Feb 13, 2023
7ba62a9
requiresPermission
ggazzo Feb 13, 2023
cb92911
collapseArrow
ggazzo Feb 13, 2023
d8c8e10
usersearch
ggazzo Feb 13, 2023
88f2e0c
SelectDropdown
ggazzo Feb 13, 2023
4feab99
loading
ggazzo Feb 13, 2023
68c50a5
error
ggazzo Feb 13, 2023
d169456
TextareaAutocomplete
ggazzo Feb 13, 2023
4386fe3
Revert "loading"
ggazzo Feb 13, 2023
7c5f4ce
make message work again
ggazzo Feb 13, 2023
1bebc6a
disable new cap
ggazzo Feb 13, 2023
c8efbb1
Merge remote-tracking branch 'origin/develop' into chore/templates
ggazzo Feb 14, 2023
82b4580
remove livestream
ggazzo Feb 14, 2023
135ed23
remove popout
ggazzo Feb 14, 2023
430c892
remove icon necessity
ggazzo Feb 14, 2023
8fb705e
Remove Modal from WebRTC
ggazzo Feb 14, 2023
c31da90
remove legacy modal usage from ActionManager
ggazzo Feb 14, 2023
b0b1323
Remove modal usage legacy from ActionManager
ggazzo Feb 14, 2023
1265802
Merge remote-tracking branch 'origin/develop' into chore/templates
ggazzo Feb 14, 2023
6e5c6a1
remove ModalBlock template
ggazzo Feb 14, 2023
01853fe
remove Template helpers
ggazzo Feb 14, 2023
67615cc
remove useBlockRendered
ggazzo Feb 14, 2023
7dd63f9
Revert "remove Template helpers"
ggazzo Feb 14, 2023
5f65c1e
Merge remote-tracking branch 'origin/develop' into chore/templates
ggazzo Feb 14, 2023
fdcdac0
Merge remote-tracking branch 'origin/develop' into chore/templates
ggazzo Feb 14, 2023
6ba32cd
Remove popover
ggazzo Feb 14, 2023
20f9258
fix lint
ggazzo Feb 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/meteor/app/authorization/client/index.ts
@@ -1,7 +1,6 @@
import { hasAllPermission, hasAtLeastOnePermission, hasPermission, userHasAllPermission } from './hasPermission';
import { hasRole, hasAnyRole } from './hasRole';
import { AuthorizationUtils } from '../lib/AuthorizationUtils';
import './requiresPermission.html';
import './startup';

export { hasAllPermission, hasAtLeastOnePermission, hasRole, hasAnyRole, hasPermission, userHasAllPermission, AuthorizationUtils };
11 changes: 0 additions & 11 deletions apps/meteor/app/authorization/client/requiresPermission.html

This file was deleted.

4 changes: 3 additions & 1 deletion apps/meteor/app/emoji/client/emojiPicker.html
Expand Up @@ -5,7 +5,9 @@
<label class="rc-input__label">
<div class="rc-input__wrapper">
<div class="rc-input__icon">
{{> icon block="rc-input__icon-svg" icon="magnifier" }}
<svg class="rc-icon rc-input__icon-svg rc-input__icon-svg--magnifier" aria-hidden="true">
<use xlink:href="{{baseUrl}}#icon-magnifier"></use>
</svg>
</div>
<input name="name" type="text" class="rc-input__element js-emojipicker-search" placeholder="{{_ "Search"}}" autofocus autocomplete="off">
</div>
Expand Down
16 changes: 16 additions & 0 deletions apps/meteor/app/emoji/client/emojiPicker.js
Expand Up @@ -9,6 +9,7 @@ import { t } from '../../utils/client';
import { EmojiPicker } from './lib/EmojiPicker';
import { emoji } from '../lib/rocketchat';
import './emojiPicker.html';
import { baseURI } from '../../../client/lib/baseURI';

const ESCAPE = 27;

Expand All @@ -22,6 +23,20 @@ const loadMoreLink = () => `<li class="emoji-picker-load-more"><a href="#load-mo

let customItems = 90;

const baseUrlFix = () => `${baseURI}${FlowRouter.current().path.substring(1)}`;

const isMozillaFirefoxBelowVersion = (upperVersion) => {
const [, version] = navigator.userAgent.match(/Firefox\/(\d+)\.\d/) || [];
return parseInt(version, 10) < upperVersion;
};

const isGoogleChromeBelowVersion = (upperVersion) => {
const [, version] = navigator.userAgent.match(/Chrome\/(\d+)\.\d/) || [];
return parseInt(version, 10) < upperVersion;
};

const isBaseUrlFixNeeded = () => isMozillaFirefoxBelowVersion(55) || isGoogleChromeBelowVersion(55);

const createEmojiList = (category, actualTone, limit = null) => {
const html =
Object.values(emoji.packages)
Expand Down Expand Up @@ -167,6 +182,7 @@ Template.emojiPicker.helpers({
currentCategory() {
return EmojiPicker.currentCategory.get();
},
baseUrl: isBaseUrlFixNeeded() ? baseUrlFix : undefined,
});

Template.emojiPicker.events({
Expand Down
50 changes: 0 additions & 50 deletions apps/meteor/app/lazy-load/client/index.js

This file was deleted.

4 changes: 0 additions & 4 deletions apps/meteor/app/lazy-load/client/lazyloadImage.html

This file was deleted.

43 changes: 0 additions & 43 deletions apps/meteor/app/lazy-load/client/lazyloadImage.js

This file was deleted.

1 change: 0 additions & 1 deletion apps/meteor/app/lazy-load/index.js

This file was deleted.

1 change: 0 additions & 1 deletion apps/meteor/app/livestream/.gitignore

This file was deleted.

10 changes: 0 additions & 10 deletions apps/meteor/app/livestream/client/index.js

This file was deleted.

22 changes: 0 additions & 22 deletions apps/meteor/app/livestream/client/oauth.js

This file was deleted.

64 changes: 0 additions & 64 deletions apps/meteor/app/livestream/client/styles/liveStreamTab.css

This file was deleted.

52 changes: 0 additions & 52 deletions apps/meteor/app/livestream/client/tabBar.tsx

This file was deleted.

5 changes: 0 additions & 5 deletions apps/meteor/app/livestream/client/views/broadcastView.html

This file was deleted.