Regression: Fixed room edit custom field validation #28078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinSchoeler
previously approved these changes
Feb 17, 2023
aleksandernsilva
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #28078 +/- ##
===========================================
- Coverage 44.82% 44.74% -0.09%
===========================================
Files 764 764
Lines 14897 14897
Branches 2069 2069
===========================================
- Hits 6678 6665 -13
- Misses 7926 7940 +14
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
reviewed
Feb 27, 2023
KevLehman
approved these changes
Feb 27, 2023
filipemarins
approved these changes
Feb 27, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes custom fields validations not being properly triggered/cleared on the room edit page.
Issue(s)
Steps to test or reproduce
Further comments
OC-679