Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Broken message jump onto threads #28095

Merged
merged 8 commits into from Feb 22, 2023
Merged

Regression: Broken message jump onto threads #28095

merged 8 commits into from Feb 22, 2023

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Feb 17, 2023 •
edited by jira bot

ARCH-141
TC-477

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 17, 2023 •
edited

Codecov Report

Merging #28095 (ba8867c) into develop (b2b8665) will decrease coverage by 12.75%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28095       +/-   ##
============================================
- Coverage    44.97%   32.22%   -12.75%     
============================================
  Files          766      628      -138     
  Lines        14894    12486     -2408     
  Branches      2068     1849      -219     
============================================
- Hits          6699     4024     -2675     
- Misses        7905     8264      +359     
+ Partials       290      198       -92
Flag Coverage Δ
e2e 32.22% <42.85%> (-12.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan added this to the 6.0.0 milestone Feb 22, 2023
@tassoevan tassoevan marked this pull request as ready for review February 22, 2023 13:36
@tassoevan tassoevan requested a review from a team as a code owner February 22, 2023 13:36
gabriellsh
gabriellsh approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 22, 2023
@kodiakhq kodiakhq bot merged commit 2089cf3 into develop Feb 22, 2023
@kodiakhq kodiakhq bot deleted the regression/thread-message-jump branch February 22, 2023 18:25
@hugocostadev hugocostadev mentioned this pull request Feb 23, 2023
Closed
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tassoevan @gabriellsh @ggazzo @jessicaschelly