New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: "Enable unlimited apps" button on installation modal doesn't do anything #28132
Regression: "Enable unlimited apps" button on installation modal doesn't do anything #28132
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28132 +/- ##
===========================================
- Coverage 44.94% 43.87% -1.08%
===========================================
Files 764 754 -10
Lines 14897 14682 -215
Branches 2069 2054 -15
===========================================
- Hits 6695 6441 -254
- Misses 7911 7973 +62
+ Partials 291 268 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/marketplace/UnlimitedAppsUpsellModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/UnlimitedAppsUpsellModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by mistake 😬 Previous comments must be solved
…nstallation-modal-doesnt-do-anything
…nstallation-modal-doesnt-do-anything
This PR currently has a merge conflict. Please resolve this and then re-add the |
…imited-apps-button-on-installation-modal-doesnt-do-anything
…nstallation-modal-doesnt-do-anything
…nstallation-modal-doesnt-do-anything
…nstallation-modal-doesnt-do-anything
…nstallation-modal-doesnt-do-anything
Proposed changes (including videos or screenshots)
This PR fixes all buttons on the "Enable unlimited apps" modal, and the problems were:
setModal(null)
properly inside a useCallback, which I noticed is a good practice and used on most of our modals._blank
.Issue(s)
Steps to test or reproduce
Further comments
MKP-246
MKP-255
MKP-256
MKP-257