Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix slash commands #28168

Merged
merged 4 commits into from Feb 28, 2023
Merged

Regression: Fix slash commands #28168

merged 4 commits into from Feb 28, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 24, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #28168 (e0a1d97) into develop (d00f7c5) will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28168      +/-   ##
===========================================
- Coverage    44.92%   44.56%   -0.36%     
===========================================
  Files          766      748      -18     
  Lines        14903    14582     -321     
  Branches      2070     2063       -7     
===========================================
- Hits          6695     6499     -196     
+ Misses        7916     7789     -127     
- Partials       292      294       +2     
Flag Coverage Δ
e2e 44.54% <100.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 25, 2023 01:15
@ggazzo ggazzo requested a review from a team February 25, 2023 01:28
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 27, 2023
@tassoevan tassoevan added this to the 6.0.0 milestone Feb 27, 2023
@tassoevan tassoevan merged commit 70320d4 into develop Feb 28, 2023
@tassoevan tassoevan deleted the regression/slash-commands branch February 28, 2023 12:41
gabriellsh added a commit that referenced this pull request Feb 28, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression:  Fix mentioning rooms with special chars (#28206)
  Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151)
  Chore: anonymous e2e test dispatch error (#28171)
  Regression: Remove unnecessary messages from Email transcript (#28165)
  Regression: Update color tokens for voip footer (#28197)
  Regression: Image Attachment Description size (#28149)
  Regression: Fix omnichannel chat forwarding not working (#28117)
  Regression: Support generating pdfs from queue (#28162)
  Regression: Regular users were not able to leave federated rooms (#28148)
  Regression: Fix slash commands (#28168)
  Regression: Incorrect installation flow on app detail and upload app pages (#28173)
  replace deprecated color tokens (#28164)
  Regression: Fix toggle theme breaking UI (#28161)
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants