Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Image Attachment Description size #28149

Merged
merged 6 commits into from Feb 28, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Feb 24, 2023

Proposed changes (including videos or screenshots)

The Image Attachment is breaking lines to match the size of the image, should follow the same size of the normal message.

Previous:
image

Current:
image

Issue(s)

Steps to test or reproduce

  1. Open a channel
  2. On the message composer, click on “+” → “Computer”
  3. Select an image from your computer
  4. Add the file description as a long text
  5. Send the image

Further comments

TC-422

@hugocostadev hugocostadev requested a review from a team as a code owner February 24, 2023 12:09
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #28149 (ac28097) into develop (3418e20) will decrease coverage by 12.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28149       +/-   ##
============================================
- Coverage    44.90%   32.24%   -12.67%     
============================================
  Files          766      628      -138     
  Lines        14903    12484     -2419     
  Branches      2070     1848      -222     
============================================
- Hits          6692     4025     -2667     
- Misses        7918     8261      +343     
+ Partials       293      198       -95     
Flag Coverage Δ
e2e 32.24% <0.00%> (-12.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 27, 2023
@hugocostadev hugocostadev added this to the 6.0.0 milestone Feb 27, 2023
@sampaiodiego sampaiodiego modified the milestone: 6.0.0 Feb 28, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@sampaiodiego sampaiodiego removed this from the 6.0.0 milestone Feb 28, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@sampaiodiego sampaiodiego added this to the 6.0.0 milestone Feb 28, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 28, 2023
@kodiakhq kodiakhq bot merged commit c75bbf8 into develop Feb 28, 2023
@kodiakhq kodiakhq bot deleted the fix/image-attachment-description branch February 28, 2023 16:02
gabriellsh added a commit that referenced this pull request Feb 28, 2023
…search-nonlatin-rooms

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression:  Fix mentioning rooms with special chars (#28206)
  Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151)
  Chore: anonymous e2e test dispatch error (#28171)
  Regression: Remove unnecessary messages from Email transcript (#28165)
  Regression: Update color tokens for voip footer (#28197)
  Regression: Image Attachment Description size (#28149)
  Regression: Fix omnichannel chat forwarding not working (#28117)
  Regression: Support generating pdfs from queue (#28162)
  Regression: Regular users were not able to leave federated rooms (#28148)
  Regression: Fix slash commands (#28168)
  Regression: Incorrect installation flow on app detail and upload app pages (#28173)
  replace deprecated color tokens (#28164)
  Regression: Fix toggle theme breaking UI (#28161)
  Chore: Remove meteor build --debug option  (#28170)
  fix: hide register workspace option for non-admin users (#28154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants