Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Save button is not enable while trying to save contact manager #28183

Merged

Conversation

FabioCavaleti
Copy link
Contributor

@FabioCavaleti FabioCavaleti commented Feb 27, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

OC-686

@FabioCavaleti FabioCavaleti self-assigned this Feb 27, 2023
@FabioCavaleti FabioCavaleti changed the title Problem solved [FIX] Save button is not enable while trying to save contact manager Feb 27, 2023
@FabioCavaleti FabioCavaleti marked this pull request as ready for review February 27, 2023 17:17
@FabioCavaleti FabioCavaleti requested a review from a team as a code owner February 27, 2023 17:17
@KevLehman KevLehman changed the title [FIX] Save button is not enable while trying to save contact manager Regression: Save button is not enable while trying to save contact manager Feb 27, 2023
@KevLehman KevLehman added this to the 6.0.0 milestone Feb 27, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #28183 (ed20e06) into develop (b3e656a) will decrease coverage by 5.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28183      +/-   ##
===========================================
- Coverage    44.88%   39.47%   -5.42%     
===========================================
  Files          764      743      -21     
  Lines        14897    14678     -219     
  Branches      2069     2031      -38     
===========================================
- Hits          6687     5794     -893     
- Misses        7918     8611     +693     
+ Partials       292      273      -19     
Flag Coverage Δ
e2e 39.44% <ø> (-5.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit ca2bdd4 into develop Mar 1, 2023
@kodiakhq kodiakhq bot deleted the fix/save-button-disabled-when-edit-contact-manager branch March 1, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants