New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Fix app status filter not working in private apps page #28198
Conversation
Fixed a bug in which the app status filter didn't work as expected because of the new 'enabled*' and 'disabled*' app status.
Codecov Report
@@ Coverage Diff @@
## develop #28198 +/- ##
===========================================
- Coverage 44.87% 44.86% -0.01%
===========================================
Files 767 767
Lines 14954 14954
Branches 2088 2088
===========================================
- Hits 6710 6709 -1
- Misses 7947 7949 +2
+ Partials 297 296 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll pretend I didn't see that you just ignored my suggestion and asked my review again expecting a different opinion
…search-nonlatin-rooms * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Apps provider not handling apps lists correctly (#28264) Regression: Fix intermitent apps engine startup (#28254) Regression: Client is not loading new settings from server (#28248) Regression: Adjusted departments upsell modal to check for licence and modules (#28246) Regression: message-parse version update (#28245) [FIX] Notify apps engine event through ms api (#28169) Chore: Add extra stats for omnichannel video calling (#28211) Regression: Adjusted components using PaginatedMultiSelected to be compatible with new Fuselage version (#28233) Regression: Change text of buttons tooltips on custom content homepage block (#28094) Regression: run clientMessageRecieved hooks on thread main message (#27962) Regression: Jump to message not working (#28163) Regression: Hide price and category filters when inside of private apps page (#28188) [BREAK] Remove support to deprecated typing event (#28234) Regression: Fix app status filter not working in private apps page (#28198) Regression: UiKit message surface styles (#28213) [FIX] Search list missing key parameter (#28230) Regression: broken message exhibition when edited (#28180) Regression: EnableUnlimitedApps button action (#28221) Regression: Update Composer Formatters Translation Keys (#28228) Regression: EmojiPicker missing shadow on dark mode (#28236) ...
Proposed changes (including videos or screenshots)
Jira task: MKP-266
Fixed a bug in which the app status filter didn't work because of the new 'enabled*' and 'disabled*' app status.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments
MKP-266