Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Show mention instead of the name of the user in app request messages #28200

Merged
merged 9 commits into from Mar 1, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Feb 27, 2023

Proposed changes (including videos or screenshots)

Jira task: MKP-249

Stopped using the name of users that requested apps and now the app request messages directly mention the users.
Demo image:
image

Issue(s)

Steps to test or reproduce

  1. Request an app in an account that doesn't have manage-app permission;
  2. Logout of that account and login into an account that has manage-app permission;
  3. Click on the rocket.cat message;

Further comments

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #28200 (912a01a) into develop (29f3f72) will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28200      +/-   ##
===========================================
- Coverage    44.87%   44.50%   -0.37%     
===========================================
  Files          766      748      -18     
  Lines        14936    14615     -321     
  Branches      2079     2072       -7     
===========================================
- Hits          6702     6504     -198     
+ Misses        7941     7815     -126     
- Partials       293      296       +3     
Flag Coverage Δ
e2e 44.47% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 changed the title Chore: Show username instead of the name of the user in app request messages Regression: Show username instead of the name of the user in app request messages Feb 28, 2023
@rique223 rique223 added this to the 6.0.0 milestone Feb 28, 2023
PedroRorato
PedroRorato previously approved these changes Feb 28, 2023
@rique223 rique223 removed the request for review from dougfabris February 28, 2023 20:57
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try create a mention instead? just the raw username is not much better the name

@rique223 rique223 requested a review from ggazzo February 28, 2023 22:37
@rique223 rique223 changed the title Regression: Show username instead of the name of the user in app request messages Regression: Show mention instead of the name of the user in app request messages Feb 28, 2023
@rique223 rique223 added the stat: ready to merge PR tested and approved waiting for merge label Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@kodiakhq kodiakhq bot merged commit 0ded95c into develop Mar 1, 2023
@kodiakhq kodiakhq bot deleted the chore/change-app-request-notify-admins-message branch March 1, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants