New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Show mention instead of the name of the user in app request messages #28200
Merged
kodiakhq
merged 9 commits into
develop
from
chore/change-app-request-notify-admins-message
Mar 1, 2023
Merged
Regression: Show mention instead of the name of the user in app request messages #28200
kodiakhq
merged 9 commits into
develop
from
chore/change-app-request-notify-admins-message
Mar 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28200 +/- ##
===========================================
- Coverage 44.87% 44.50% -0.37%
===========================================
Files 766 748 -18
Lines 14936 14615 -321
Branches 2079 2072 -7
===========================================
- Hits 6702 6504 -198
+ Misses 7941 7815 -126
- Partials 293 296 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
rique223
changed the title
Chore: Show username instead of the name of the user in app request messages
Regression: Show username instead of the name of the user in app request messages
Feb 28, 2023
PedroRorato
previously approved these changes
Feb 28, 2023
ggazzo
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you try create a mention instead? just the raw username is not much better the name
ggazzo
reviewed
Feb 28, 2023
…ub.com:RocketChat/Rocket.Chat into chore/change-app-request-notify-admins-message
rique223
changed the title
Regression: Show username instead of the name of the user in app request messages
Regression: Show mention instead of the name of the user in app request messages
Feb 28, 2023
ggazzo
approved these changes
Mar 1, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 1, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 1, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 1, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
squad: apps ecosystem
AECO
stat: QA skipped
stat: ready to merge
PR tested and approved waiting for merge
type: regression
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: MKP-249
Stopped using the name of users that requested apps and now the app request messages directly mention the users.
Demo image:
Issue(s)
Steps to test or reproduce
Further comments