feat: New timeout setting for Omnichannel Webhooks #28219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
cauefcr
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cauefcr
changed the title
aleksandernsilva
previously approved these changes
Mar 1, 2023
KevLehman
previously requested changes
Mar 1, 2023
murtaza98
reviewed
Mar 2, 2023
murtaza98
reviewed
Mar 2, 2023
murtaza98
added
the
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
This comment was marked as outdated.
This comment was marked as outdated.
sampaiodiego
previously approved these changes
Apr 5, 2023
KevLehman
previously approved these changes
Apr 13, 2023
aleksandernsilva
previously approved these changes
Apr 13, 2023
MartinSchoeler
dismissed stale reviews from KevLehman and aleksandernsilva
via
3a13763
MartinSchoeler
approved these changes
Apr 14, 2023
KevLehman
approved these changes
Apr 14, 2023
sampaiodiego
approved these changes
Apr 14, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Costumers were complaining about duplicated data from the Omnichannel webhooks, so I added a new setting that controls the timeouts for the webhooks, in the omnichannel->webhooks panel, the default values are 5s for http timeout, and 4x that for the retry timeout, or 20s.
Issue(s)
OC-511
Steps to test or reproduce
Configure and send an invalid webhook, it should take 20s to retry, instead of the usual 10s.
Further comments