Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix remove user from room shows skeleton #28247

Merged
merged 7 commits into from Mar 6, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Mar 2, 2023

Proposed changes (including videos or screenshots)

When the user is removed from a public channel and has it open it will show a grey placeholder screen

Now, it appears the Join button as usual

Issue(s)

Steps to test or reproduce

  1. Open a public channel with user A
  2. Add member B
  3. Open the channel on both users
  4. With user A, remove user B from the channel

Further comments

TC-509

@hugocostadev hugocostadev requested a review from a team as a code owner March 2, 2023 18:43
@hugocostadev hugocostadev added this to the 6.0.0 milestone Mar 2, 2023
@hugocostadev hugocostadev changed the title fix remove user skeleton room Regression: Fix remove user from room shows skeleton Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #28247 (974d3bc) into develop (de9a843) will increase coverage by 3.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28247      +/-   ##
===========================================
+ Coverage    32.47%   35.79%   +3.31%     
===========================================
  Files          634      690      +56     
  Lines        12574    13811    +1237     
  Branches      1869     1993     +124     
===========================================
+ Hits          4083     4943     +860     
- Misses        8290     8632     +342     
- Partials       201      236      +35     
Flag Coverage Δ
e2e 35.78% <ø> (+3.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@kodiakhq kodiakhq bot merged commit a2537e4 into develop Mar 6, 2023
33 checks passed
@kodiakhq kodiakhq bot deleted the regression/remove-user branch March 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants