New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Fix remove user from room shows skeleton #28247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocostadev
changed the title
fix remove user skeleton room
Regression: Fix remove user from room shows skeleton
Mar 2, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28247 +/- ##
===========================================
+ Coverage 32.47% 35.79% +3.31%
===========================================
Files 634 690 +56
Lines 12574 13811 +1237
Branches 1869 1993 +124
===========================================
+ Hits 4083 4943 +860
- Misses 8290 8632 +342
- Partials 201 236 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
guijun13
approved these changes
Mar 3, 2023
tassoevan
approved these changes
Mar 4, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Mar 4, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 4, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 6, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 6, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 6, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When the user is removed from a public channel and has it open it will show a grey placeholder screen
Now, it appears the Join button as usual
Issue(s)
Steps to test or reproduce
Further comments
TC-509