refactor: RoomInfo to typescript
#28250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28250 +/- ##
===========================================
+ Coverage 45.06% 45.16% +0.10%
===========================================
Files 758 754 -4
Lines 14683 14597 -86
Branches 2074 2082 +8
===========================================
- Hits 6617 6593 -24
+ Misses 7773 7709 -64
- Partials 293 295 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
changed the title
RoomInfo to typescriptRoomInfo to typescript
tassoevan
requested changes
Mar 10, 2023
apps/meteor/client/views/room/contextualBar/Info/RoomInfo/RoomInfoWithData.tsx
Outdated
Show resolved
Hide resolved
tassoevan
requested changes
Mar 10, 2023
packages/rest-typings/src/v1/groups/GroupsConvertToTeamProps.ts
Outdated
Show resolved
Hide resolved
tassoevan
approved these changes
Mar 15, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments