Regression: Adjusted departments upsell modal message #28258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandernsilva
changed the title
filipemarins
previously approved these changes
Mar 3, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28258 +/- ##
===========================================
- Coverage 44.92% 43.77% -1.16%
===========================================
Files 771 761 -10
Lines 14984 14769 -215
Branches 2091 2076 -15
===========================================
- Hits 6732 6465 -267
- Misses 7954 8030 +76
+ Partials 298 274 -24
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
reviewed
Mar 3, 2023
apps/meteor/client/components/Omnichannel/modals/EnterpriseDepartmentsModal.tsx
Outdated
Show resolved
Hide resolved
KevLehman
approved these changes
Mar 6, 2023
MartinSchoeler
approved these changes
Mar 6, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR adjusts the logic to display the correct message on the departments upsell modal. This affects users with a trial license, expired expired licence, as well as no licence.
Issue(s)
Steps to test or reproduce
Further comments
OC-712