Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Disabled grandfathered apps must have the option to be enabled #28266

Merged
merged 3 commits into from Mar 6, 2023

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Mar 3, 2023

Proposed changes (including videos or screenshots)

Grandfathered apps will not follow the new enabling flow and it should always be possible to enable them

Issue(s)

Steps to test or reproduce

Further comments

MKP-273

@d-gubert d-gubert requested a review from a team as a code owner March 3, 2023 22:42
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #28266 (b217eaf) into develop (0e969e9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head b217eaf differs from pull request most recent head 83ccd22. Consider uploading reports for the commit 83ccd22 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28266      +/-   ##
===========================================
- Coverage    44.92%   44.92%   -0.01%     
===========================================
  Files          771      771              
  Lines        14984    14984              
  Branches      2091     2091              
===========================================
- Hits          6732     6731       -1     
- Misses        7954     7955       +1     
  Partials       298      298              
Flag Coverage Δ
e2e 44.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added this to the 6.0.0 milestone Mar 3, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@kodiakhq kodiakhq bot merged commit 625f93d into develop Mar 6, 2023
@kodiakhq kodiakhq bot deleted the regression/enabled-migrated-apps branch March 6, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants