Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Scrolling on threads #28298

Merged
merged 4 commits into from Mar 6, 2023
Merged

Regression: Scrolling on threads #28298

merged 4 commits into from Mar 6, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Mar 6, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Actual behavior

Sometimes scrolling in a Thread doesn't work to the top of the message

Expected Behavior

Scrolling in threads should work fine and scrollbar shouldn't come to bottom upon resizing the window.

Further comments

TC-516

@yash-rajpal yash-rajpal requested a review from a team as a code owner March 6, 2023 17:53
@yash-rajpal yash-rajpal added this to the 6.0.0 milestone Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #28298 (5f70c2c) into develop (a2537e4) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

❗ Current head 5f70c2c differs from pull request most recent head 96f8468. Consider uploading reports for the commit 96f8468 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28298      +/-   ##
===========================================
- Coverage    44.96%   44.90%   -0.07%     
===========================================
  Files          771      771              
  Lines        14985    14985              
  Branches      2092     2092              
===========================================
- Hits          6738     6729       -9     
- Misses        7950     7958       +8     
- Partials       297      298       +1     
Flag Coverage Δ
e2e 44.86% <50.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 6, 2023
@kodiakhq kodiakhq bot merged commit b236a5c into develop Mar 6, 2023
32 checks passed
@kodiakhq kodiakhq bot deleted the reg/threads-scroll branch March 6, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants