Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RegisterUsername #28362

Merged
merged 11 commits into from Mar 13, 2023
Merged

refactor: RegisterUsername #28362

merged 11 commits into from Mar 13, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 10, 2023 •
edited

Proposed changes (including videos or screenshots)

Screen Shot 2023-03-10 at 18 26 01

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris changed the title Chore: Refactor RegisterUsername refactor: RegisterUsername Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023 •
edited

Codecov Report

Merging #28362 (67b6548) into develop (2b404b4) will decrease coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28362      +/-   ##
===========================================
- Coverage    45.26%   45.16%   -0.11%     
===========================================
  Files          760      758       -2     
  Lines        14802    14680     -122     
  Branches      2087     2068      -19     
===========================================
- Hits          6700     6630      -70     
+ Misses        7808     7758      -50     
+ Partials       294      292       -2
Flag Coverage Δ
e2e 45.12% <50.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.1.0 milestone Mar 13, 2023
@dougfabris dougfabris marked this pull request as ready for review March 13, 2023 19:49
@dougfabris dougfabris requested review from a team as code owners March 13, 2023 19:49
ggazzo
ggazzo previously approved these changes Mar 13, 2023
View reviewed changes
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2023
@ggazzo ggazzo merged commit 2cf41d0 into develop Mar 13, 2023
36 checks passed
@ggazzo ggazzo deleted the chore/refactor-register-username branch March 13, 2023 21:51
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dougfabris @ggazzo @casalsgh