refactor: Remove Promise.await calls from importer classes
#28404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28404 +/- ##
===========================================
- Coverage 45.13% 43.93% -1.20%
===========================================
Files 758 748 -10
Lines 14681 14467 -214
Branches 2070 2056 -14
===========================================
- Hits 6626 6356 -270
- Misses 7762 7839 +77
+ Partials 293 272 -21
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
changed the title
Promise.await calls from importer classes
sampaiodiego
approved these changes
Mar 14, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-420
[ARCH-421]
[ARCH-422]
[ARCH-423]
[ARCH-424]
Steps to test or reproduce
Further comments