Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Routing fixed for private apps in marketplace section #28418

Merged
merged 3 commits into from Mar 15, 2023

Conversation

ayush3160
Copy link
Contributor

Proposed changes (including videos or screenshots)

This pull request fixes the irregular behavior of routing in the Private Apps section of the Marketplace. The issue was caused by the passing of three parameters (id of app, marketplaceVersion, and tab) to the route when opening an app's details. In the case of private apps, the marketplaceVersion was returning undefined, which caused the version to take on the value of the tab when redirecting. To resolve this issue, I have updated the code to pass the version of the app when the marketplaceVersion returns undefined. This fix ensures that the routes behave as expected in the Private Apps section of the Marketplace.

Rocket.Chat.-.14.March.2023.mp4

Issue(s)

#28378

Steps to test or reproduce

  1. Open the Private apps section of marketplace. http://localhost:3000/marketplace/private/list
  2. Click on any installed app , it will redirect to details page of the app.
  3. Now open the logs of app and notice the route (/${version_of_app}/logs).

Further comments

@ayush3160 ayush3160 requested a review from a team as a code owner March 14, 2023 17:45
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023

CLA assistant check
All committers have signed the CLA.

@ayush3160 ayush3160 changed the title Reporting fixed for private apps in marketplace section Routing fixed for private apps in marketplace section Mar 14, 2023
@ayush3160 ayush3160 changed the title Routing fixed for private apps in marketplace section fix: Routing fixed for private apps in marketplace section Mar 14, 2023
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@yash-rajpal yash-rajpal self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@cb4699e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #28418   +/-   ##
==========================================
  Coverage           ?   44.55%           
==========================================
  Files              ?      736           
  Lines              ?    14280           
  Branches           ?     2078           
==========================================
  Hits               ?     6362           
  Misses             ?     7619           
  Partials           ?      299           
Flag Coverage Δ
e2e 44.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal added stat: ready to merge PR tested and approved waiting for merge stat: QA skipped and removed stat: needs QA labels Mar 15, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 15, 2023
@kodiakhq kodiakhq bot merged commit ddf677c into RocketChat:develop Mar 15, 2023
34 checks passed
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants