New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Routing fixed for private apps in marketplace section #28418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayush3160
changed the title
Reporting fixed for private apps in marketplace section
Routing fixed for private apps in marketplace section
Mar 14, 2023
ayush3160
changed the title
Routing fixed for private apps in marketplace section
fix: Routing fixed for private apps in marketplace section
Mar 14, 2023
ayush3160
force-pushed
the
develop-changes
branch
from
March 14, 2023 18:18
f521b11
to
276c1c2
Compare
yash-rajpal
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
tiagoevanp
approved these changes
Mar 14, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28418 +/- ##
==========================================
Coverage ? 44.55%
==========================================
Files ? 736
Lines ? 14280
Branches ? 2078
==========================================
Hits ? 6362
Misses ? 7619
Partials ? 299
Flags with carried forward coverage won't be shown. Click here to find out more. |
yash-rajpal
added
stat: ready to merge
PR tested and approved waiting for merge
stat: QA skipped
and removed
stat: needs QA
labels
Mar 15, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This pull request fixes the irregular behavior of routing in the Private Apps section of the Marketplace. The issue was caused by the passing of three parameters (id of app, marketplaceVersion, and tab) to the route when opening an app's details. In the case of private apps, the marketplaceVersion was returning undefined, which caused the version to take on the value of the tab when redirecting. To resolve this issue, I have updated the code to pass the version of the app when the marketplaceVersion returns undefined. This fix ensures that the routes behave as expected in the Private Apps section of the Marketplace.
Rocket.Chat.-.14.March.2023.mp4
Issue(s)
#28378
Steps to test or reproduce
Further comments