fix: check if custom field is required to apply rule #28428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksandernsilva
previously approved these changes
Mar 15, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28428 +/- ##
===========================================
+ Coverage 45.35% 45.37% +0.01%
===========================================
Files 728 726 -2
Lines 14200 14278 +78
Branches 2189 2211 +22
===========================================
+ Hits 6441 6478 +37
- Misses 7455 7493 +38
- Partials 304 307 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
filipemarins
force-pushed
the
fix/required
branch
from
7028c74
to
ee5749e
Compare
filipemarins
force-pushed
the
fix/required
branch
from
ee5749e
to
97cc97d
Compare
dionisio-bot
bot
added
stat: ready to merge
MartinSchoeler
approved these changes
Mar 23, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
aleksandernsilva
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 6, 2023
…fullName * 'develop' of github.com:RocketChat/Rocket.Chat: (134 commits) refactor(Meteor.user): Remove all occurrences (#28647) refactor: Remove unused meteor packages (#28821) fix: check if custom field is required to apply rule (#28428) fix: Confirm password flow fixed and refactored (#28453) refactor(file.server): Remove wrapAsync and convert to TS (#28823) refactor(client): `openRoom` dilluted into components (#28794) refactor: Isolate last Promise.await calls on accounts’ code (#28817) refactor: `Service Configuration` async on server (#28813) refactor: `utils` to ts (#28818) refactor: Remove fibers from `rocketchat-version` package (#28776) refactor: convert apps api to ts (#28815) refactor: Remove Promise.await from importer-pendind-file.js (#28812) refactor: Remove promise.await from csv importer (#28810) refactor: Isolate Promise.await of updateOrCreateUserFromExternalService (#28811) regression: remove callbacks from `Meteor.callAsync` (#28809) refactor: Move from `meteor/http` to `meteor/fetch` - 2x (#28799) refactor: Remove unnecessary Tokens collection and Fibers usage (#28803) regression: add missing await for RocketChatFile (#28807) refactor: Remove fibers from Users Model (#28797) ci: add branch config back to checkout action (#28802) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fix save button is not enabled until non-required custom fields are not filled under room information.
Issue(s)
OC-823
Steps to test or reproduce
Further comments