refactor: Convert rooms endpoints to TS #28448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosSpessatto
requested review from
ggazzo,
KevLehman,
sampaiodiego and
pierre-lehnen-rc
MarcosSpessatto
commented
Mar 16, 2023
MarcosSpessatto
removed request for
ggazzo,
sampaiodiego,
KevLehman and
pierre-lehnen-rc
…ocketChat/Rocket.Chat into refactor/convert-rooms-endpoints-to-ts
Codecov Report
@@ Coverage Diff @@
## develop #28448 +/- ##
===========================================
- Coverage 45.05% 36.32% -8.74%
===========================================
Files 755 697 -58
Lines 14614 13926 -688
Branches 2094 2034 -60
===========================================
- Hits 6585 5058 -1527
- Misses 7730 8602 +872
+ Partials 299 266 -33
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously approved these changes
Mar 17, 2023
ggazzo
approved these changes
Mar 17, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 21, 2023
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (40 commits) refactor(promise.await): saveUserIdentity.ts, saveUser.js, relinquishRoomOwnerships.ts and deleteMessage.ts (#28493) refactor: Remove `FederationRoomEvents` model (#28488) refactor: Promise.await removal (#28481) refactor: move from canDeleteMessage to canDeleteMessageAsync (#28480) refactor: move from canAccessRoom to canAccessRoomAsync (#28477) refactor: convert getRoomRoles to async (#28485) refactor: Remove `Promise.await` calls from Slack Adapter (#28408) chore: make callbacks accept async (#28486) fix: Horizontal scroll in main room if text is too long (#28434) refactor: Types of Meteor methods (7/N) (#28482) refactor: Models feature parity (#28456) refactor: Types of Meteor methods (5/N) (#28461) refactor: Types of Meteor methods (6/N) (#28478) refactor: Convert rooms endpoints to TS (#28448) refactor: Convert groups endpoints to typescript (#28432) refactor: Convert channels endpoints to TS (#28469) refactor: Convert chat endpoints to TS (#28417) chore: Remove invalid `aria-description` from list menus (#28471) fix: videoconf stream (#28455) Chore(deps): Bump supercharge/mongodb-github-action from 1.7.0 to 1.9.0 (#28003) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR converts all the (missing)
rooms.endpoints to Typescript.Jira: ARCH-166
Issue(s)
Steps to test or reproduce
Further comments