New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move from canAccessRoom to canAccessRoomAsync #28477
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28477 +/- ##
===========================================
- Coverage 45.08% 45.00% -0.08%
===========================================
Files 755 755
Lines 14617 14614 -3
Branches 2096 2094 -2
===========================================
- Hits 6590 6577 -13
- Misses 7729 7738 +9
- Partials 298 299 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omnichannel side changes looks good!
ff0f934
to
65b9418
Compare
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (40 commits) refactor(promise.await): saveUserIdentity.ts, saveUser.js, relinquishRoomOwnerships.ts and deleteMessage.ts (#28493) refactor: Remove `FederationRoomEvents` model (#28488) refactor: Promise.await removal (#28481) refactor: move from canDeleteMessage to canDeleteMessageAsync (#28480) refactor: move from canAccessRoom to canAccessRoomAsync (#28477) refactor: convert getRoomRoles to async (#28485) refactor: Remove `Promise.await` calls from Slack Adapter (#28408) chore: make callbacks accept async (#28486) fix: Horizontal scroll in main room if text is too long (#28434) refactor: Types of Meteor methods (7/N) (#28482) refactor: Models feature parity (#28456) refactor: Types of Meteor methods (5/N) (#28461) refactor: Types of Meteor methods (6/N) (#28478) refactor: Convert rooms endpoints to TS (#28448) refactor: Convert groups endpoints to typescript (#28432) refactor: Convert channels endpoints to TS (#28469) refactor: Convert chat endpoints to TS (#28417) chore: Remove invalid `aria-description` from list menus (#28471) fix: videoconf stream (#28455) Chore(deps): Bump supercharge/mongodb-github-action from 1.7.0 to 1.9.0 (#28003) ...
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments