refactor: Remove ImportData meteor model
#28458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28458 +/- ##
===========================================
+ Coverage 32.74% 33.00% +0.26%
===========================================
Files 620 634 +14
Lines 12273 12579 +306
Branches 1865 1853 -12
===========================================
+ Hits 4019 4152 +133
- Misses 8052 8215 +163
- Partials 202 212 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
force-pushed
the
refactor/import-data-model
branch
from
5dc6fd0
to
183f9f5
Compare
KevLehman
changed the title
ImportData meteor model
pierre-lehnen-rc
requested changes
Mar 20, 2023
There was a problem hiding this comment.
Actually, can you leave the whole Connection.ts file untouched (adding Promise.awaits elsewhere)?
Instead of reworking the ldap to work asynchronously, I'll split the Virtual Importer from the Base code so that the BaseImporter will be async and Virtual continues to be sync.
… refactor/import-data-model
pierre-lehnen-rc
approved these changes
Mar 20, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARCH-918
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments