refactor(promise.await): createRoom.ts, createDirectRoom.ts and cleanRoomHistory.ts #28492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romise-await # Conflicts: # apps/meteor/app/cas/server/cas_server.js # apps/meteor/app/lib/server/methods/createChannel.ts # apps/meteor/ee/server/lib/ldap/Manager.ts
…romise-await # Conflicts: # apps/meteor/app/slackbridge/server/SlackAdapter.js # apps/meteor/app/utils/lib/slashCommand.ts
KevLehman
previously approved these changes
Mar 20, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28492 +/- ##
===========================================
- Coverage 45.12% 36.87% -8.25%
===========================================
Files 755 648 -107
Lines 14617 12691 -1926
Branches 2096 1873 -223
===========================================
- Hits 6596 4680 -1916
- Misses 7723 7773 +50
+ Partials 298 238 -60
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
approved these changes
Mar 20, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/ARCH-431
https://rocketchat.atlassian.net/browse/ARCH-432
https://rocketchat.atlassian.net/browse/ARCH-433
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments