New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Apps.engine resource consumption #28514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28514 +/- ##
===========================================
+ Coverage 45.01% 45.04% +0.02%
===========================================
Files 755 755
Lines 14618 14618
Branches 2096 2096
===========================================
+ Hits 6581 6584 +3
+ Misses 7740 7735 -5
- Partials 297 299 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
reviewed
Mar 21, 2023
d-gubert
approved these changes
Mar 21, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Mar 21, 2023
dionisio-bot
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Mar 21, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 21, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 21, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 22, 2023
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 22, 2023
d-gubert
added a commit
that referenced
this pull request
Mar 22, 2023
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
Closed
d-gubert
added a commit
that referenced
this pull request
Mar 23, 2023
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
Merged
Dnouv
pushed a commit
to Dnouv/Rocket.Chat
that referenced
this pull request
Apr 11, 2023
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added some validations to avoid doing unnecessary updates and also avoid loop that causes high server usage
Issue(s)
Steps to test or reproduce
Further comments