Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps.engine resource consumption #28514

Merged
merged 9 commits into from Mar 22, 2023
Merged

Conversation

tapiarafael
Copy link
Contributor

Proposed changes (including videos or screenshots)

Added some validations to avoid doing unnecessary updates and also avoid loop that causes high server usage

Issue(s)

Steps to test or reproduce

  1. Install an app that has configuration options;
  2. Change any settings;
  3. Save the changes;

Further comments

@tapiarafael tapiarafael marked this pull request as ready for review March 21, 2023 01:42
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #28514 (f0bd3c6) into develop (faad471) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28514      +/-   ##
===========================================
+ Coverage    45.01%   45.04%   +0.02%     
===========================================
  Files          755      755              
  Lines        14618    14618              
  Branches      2096     2096              
===========================================
+ Hits          6581     6584       +3     
+ Misses        7740     7735       -5     
- Partials       297      299       +2     
Flag Coverage Δ
e2e 44.99% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert added this to the 6.0.1 milestone Mar 21, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2023
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Mar 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 22, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 22, 2023
@kodiakhq kodiakhq bot merged commit 4aa5794 into develop Mar 22, 2023
39 checks passed
@kodiakhq kodiakhq bot deleted the fix/apps-settings-loop branch March 22, 2023 12:48
d-gubert added a commit that referenced this pull request Mar 22, 2023
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
@d-gubert d-gubert mentioned this pull request Mar 22, 2023
d-gubert added a commit that referenced this pull request Mar 23, 2023
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
@d-gubert d-gubert mentioned this pull request Mar 23, 2023
Dnouv pushed a commit to Dnouv/Rocket.Chat that referenced this pull request Apr 11, 2023
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants