New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move Subscriptions
1x
#28531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28531 +/- ##
========================================
Coverage 45.04% 45.04%
========================================
Files 753 753
Lines 14662 14662
Branches 2129 2129
========================================
Hits 6605 6605
+ Misses 7755 7754 -1
- Partials 302 303 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
requested changes
Mar 22, 2023
Co-authored-by: Diego Sampaio <chinello@gmail.com>
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Mar 23, 2023
ggazzo
requested changes
Mar 23, 2023
…Rocket.Chat into refactor/subscriptions-model
dionisio-bot
bot
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Mar 23, 2023
ggazzo
approved these changes
Mar 23, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 23, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: (141 commits) ci(docker): use correct var name fix: Prevent blank space on live chat form validations (#28243) ci(docker): Push Docker tag for commit hash (#28578) fix: marketplace doc link wrong redirect (#28466) refactor: move `Subscriptions` 1x (#28531) chore: ignore `.eslintcache` (#28475) refactor: convert omnichannel callbacks to ts (#28564) refactor: Allow RoomCoordinator.roomFind to be async (#28566) refactor(models): Use Messages Raw model (4/N) (#28558) refactor(client): `meteor/session` usage (1/N) (#28565) refactor: Don't use meteor collections on migrations (#28563) feat: VideoConference Guest mode and Conference Router (#28186) refactor: promise.await removal 8/N (#28560) refactor: checkUsernameAvailability to async (#28557) refactor(promise.await): Low hanging fruits (2/2) (#28556) fix: Changing the app's error verification (#28450) refactor(promise.await): Low hanging fruits (1/N) (#28555) fix: Thread message preview (#28454) refactor: remove Promise.await from LDAP files (#28527) refactor: canAccessRoomId to async (#28540) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARCH-931
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments