Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move Subscriptions 1x #28531

Merged
merged 11 commits into from Mar 23, 2023
Merged

refactor: move Subscriptions 1x #28531

merged 11 commits into from Mar 23, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 21, 2023

ARCH-931

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #28531 (2bf24ed) into develop (7dd7186) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #28531   +/-   ##
========================================
  Coverage    45.04%   45.04%           
========================================
  Files          753      753           
  Lines        14662    14662           
  Branches      2129     2129           
========================================
  Hits          6605     6605           
+ Misses        7755     7754    -1     
- Partials       302      303    +1     
Flag Coverage Δ
e2e 45.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review March 22, 2023 13:40
@KevLehman KevLehman requested a review from a team March 22, 2023 19:45
apps/meteor/server/models/raw/Subscriptions.ts Outdated Show resolved Hide resolved
apps/meteor/server/models/raw/Subscriptions.ts Outdated Show resolved Hide resolved
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 23, 2023
@KevLehman KevLehman requested a review from ggazzo March 23, 2023 13:35
…Rocket.Chat into refactor/subscriptions-model
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 23, 2023
@ggazzo ggazzo merged commit 1fbb6f8 into develop Mar 23, 2023
36 checks passed
@ggazzo ggazzo deleted the refactor/subscriptions-model branch March 23, 2023 14:33
gabriellsh added a commit that referenced this pull request Mar 23, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat: (141 commits)
  ci(docker): use correct var name
  fix: Prevent blank space on live chat form validations (#28243)
  ci(docker): Push Docker tag for commit hash (#28578)
  fix: marketplace doc link wrong redirect (#28466)
  refactor: move `Subscriptions` 1x (#28531)
  chore: ignore `.eslintcache` (#28475)
  refactor: convert omnichannel callbacks to ts (#28564)
  refactor: Allow RoomCoordinator.roomFind to be async (#28566)
  refactor(models): Use Messages Raw model (4/N) (#28558)
  refactor(client): `meteor/session` usage (1/N) (#28565)
  refactor: Don't use meteor collections on migrations (#28563)
  feat: VideoConference Guest mode and Conference Router (#28186)
  refactor: promise.await removal 8/N (#28560)
  refactor: checkUsernameAvailability to async (#28557)
  refactor(promise.await): Low hanging fruits (2/2) (#28556)
  fix: Changing the app's error verification (#28450)
  refactor(promise.await): Low hanging fruits (1/N) (#28555)
  fix: Thread message preview (#28454)
  refactor: remove Promise.await from LDAP files (#28527)
  refactor: canAccessRoomId to async (#28540)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants