Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): Push Docker tag for commit hash #28578

Merged
merged 2 commits into from Mar 23, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

The new Docker tag will be like sha-607e6f9.

I've added logs of all tags published.

This changes can only be tested/seen once it gets merged to develop 😬

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner March 23, 2023 14:24
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #28578 (2ca2917) into develop (7dd7186) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28578      +/-   ##
===========================================
+ Coverage    45.04%   45.10%   +0.06%     
===========================================
  Files          753      753              
  Lines        14662    14662              
  Branches      2129     2129              
===========================================
+ Hits          6605     6614       +9     
+ Misses        7755     7747       -8     
+ Partials       302      301       -1     
Flag Coverage Δ
e2e 45.06% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit 856c7f5 into develop Mar 23, 2023
34 of 35 checks passed
@sampaiodiego sampaiodiego deleted the publish-docker-image-for-commit-hash branch March 23, 2023 16:45
gabriellsh added a commit that referenced this pull request Mar 23, 2023
…ixSearch

* 'develop' of github.com:RocketChat/Rocket.Chat: (141 commits)
  ci(docker): use correct var name
  fix: Prevent blank space on live chat form validations (#28243)
  ci(docker): Push Docker tag for commit hash (#28578)
  fix: marketplace doc link wrong redirect (#28466)
  refactor: move `Subscriptions` 1x (#28531)
  chore: ignore `.eslintcache` (#28475)
  refactor: convert omnichannel callbacks to ts (#28564)
  refactor: Allow RoomCoordinator.roomFind to be async (#28566)
  refactor(models): Use Messages Raw model (4/N) (#28558)
  refactor(client): `meteor/session` usage (1/N) (#28565)
  refactor: Don't use meteor collections on migrations (#28563)
  feat: VideoConference Guest mode and Conference Router (#28186)
  refactor: promise.await removal 8/N (#28560)
  refactor: checkUsernameAvailability to async (#28557)
  refactor(promise.await): Low hanging fruits (2/2) (#28556)
  fix: Changing the app's error verification (#28450)
  refactor(promise.await): Low hanging fruits (1/N) (#28555)
  fix: Thread message preview (#28454)
  refactor: remove Promise.await from LDAP files (#28527)
  refactor: canAccessRoomId to async (#28540)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants