refactor: make roomcoordinator.roomName async
#28609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionisio-bot
bot
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #28609 +/- ##
===========================================
+ Coverage 43.92% 44.98% +1.06%
===========================================
Files 743 753 +10
Lines 14451 14665 +214
Branches 2116 2130 +14
===========================================
+ Hits 6347 6597 +250
+ Misses 7816 7764 -52
- Partials 288 304 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
approved these changes
Mar 24, 2023
|
Yup, will refactor those on a separate PR |
dionisio-bot
bot
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments