Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #28762 - fix missing command in /help #28777

Merged

Conversation

adarshlilha
Copy link
Contributor

@adarshlilha adarshlilha commented Apr 3, 2023

fix missing command for: "Mark all messages as read" - under /help
closes #28762

Proposed changes (including videos or screenshots)

When using /help command in any room the rocket.cat bot lists all keyboard shortcuts for the operations that can be done in rocket chat but for one command(marking all messages as read) shortcut is not being renderered

before fix screenshot:
Screenshot 2023-04-03 at 23 49 21

post fix screenshot:
Screenshot 2023-04-03 at 23 49 21

Issue(s)

closes #28762

Steps to test or reproduce

  • open any channel
  • type "/help" and press enter(return) key
  • bot responds with a list of commands with their description
  • notice here for 2nd command - "Mark all messages as read" - the shortcut command is missing

all commands must have the shortcut command as well

Further comments

this PR adds the missing placeholder for mark all messages as read command for English(en) language

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@ef57d6a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #28777   +/-   ##
==========================================
  Coverage           ?   44.22%           
==========================================
  Files              ?      717           
  Lines              ?    14075           
  Branches           ?     2199           
==========================================
  Hits               ?     6224           
  Misses             ?     7559           
  Partials           ?      292           
Flag Coverage Δ
e2e 44.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2023
@kodiakhq kodiakhq bot merged commit 0460599 into RocketChat:develop Apr 4, 2023
33 checks passed
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rocket.cat help command not showing the shortcut for one
2 participants