fix: Remove HTML from settings descriptions #28946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation setting description
Codecov Report
@@ Coverage Diff @@
## develop #28946 +/- ##
===========================================
+ Coverage 46.68% 46.75% +0.07%
===========================================
Files 698 699 +1
Lines 13071 13087 +16
Branches 2226 2228 +2
===========================================
+ Hits 6102 6119 +17
+ Misses 6652 6647 -5
- Partials 317 321 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Also changed MarkdownText variant from inline to document
…Class_Description
hugocostadev
dismissed stale reviews from KevLehman, felipe-rod123, and debdutdeb
via
b8ae613
KevLehman
previously approved these changes
May 30, 2023
debdutdeb
previously approved these changes
May 30, 2023
ggazzo
previously requested changes
Jun 7, 2023
debdutdeb
approved these changes
Jun 12, 2023
hugocostadev
dismissed
ggazzo’s stale review
Not a bug, it's a improvement that will be done later
ggazzo
approved these changes
Jun 13, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Setting descriptions stopped accepting HTML and because of that several setting had incorrect descriptions.
HTML tags/formatting was replaced by markdown.
Issue(s)
fix #28960
Steps to test or reproduce
Further comments
WM-1