regression: Fixed livechat notifications displaying [object Promise] on title #29021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-6.2.0 #29021 +/- ##
=================================================
+ Coverage 45.70% 46.18% +0.47%
=================================================
Files 709 728 +19
Lines 13761 14088 +327
Branches 2186 2193 +7
=================================================
+ Hits 6290 6506 +216
- Misses 7155 7272 +117
+ Partials 316 310 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
murtaza98
approved these changes
Apr 24, 2023
KevLehman
approved these changes
Apr 24, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 27, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: (54 commits) feat: Add support to search for public rooms through the Matrix Network (#28330) chore: Improve bash script and add new detailed infos (#29066) chore: Remove duplicated key in turbo.json (#29057) chore: improve unread indicator colors (#29045) fix: Notification badge background (#29053) fix: `JumpToMessages` button style (#29033) refactor: Remove imports based on isomorphic logic - 2 (#29065) refactor: Move `cloud` and `channel settings` to typescript (#28907) refactor: Separate isomorphic imports on utils - 1 (#29052) fix: bug in close method of RoomManager occurs memory leak (#29058) refactor: Remove Meteor.userId from Slashcommands (#28925) refactor: Move callbacks to async (#29051) Bump version to 6.2.0-rc.4 refactor: No reference to jQuery types (#28977) regression: SlackBridge settings UI crashing (#29050) fix: `HeaderTag` (#28961) chore(deps): Patch dependencies (#29024) regression: Fixed livechat notifications displaying [object Promise] on title (#29021) regression: `fetch` response (#29032) refactor: Remove `meteor/http` for `serverFetch` (#29038) ...
gabriellsh
added a commit
that referenced
this pull request
Apr 27, 2023
…externalAvatarProvider * 'develop' of github.com:RocketChat/Rocket.Chat: (88 commits) feat: Add support to search for public rooms through the Matrix Network (#28330) chore: Improve bash script and add new detailed infos (#29066) chore: Remove duplicated key in turbo.json (#29057) chore: improve unread indicator colors (#29045) fix: Notification badge background (#29053) fix: `JumpToMessages` button style (#29033) refactor: Remove imports based on isomorphic logic - 2 (#29065) refactor: Move `cloud` and `channel settings` to typescript (#28907) refactor: Separate isomorphic imports on utils - 1 (#29052) fix: bug in close method of RoomManager occurs memory leak (#29058) refactor: Remove Meteor.userId from Slashcommands (#28925) refactor: Move callbacks to async (#29051) Bump version to 6.2.0-rc.4 refactor: No reference to jQuery types (#28977) regression: SlackBridge settings UI crashing (#29050) fix: `HeaderTag` (#28961) chore(deps): Patch dependencies (#29024) regression: Fixed livechat notifications displaying [object Promise] on title (#29021) regression: `fetch` response (#29032) refactor: Remove `meteor/http` for `serverFetch` (#29038) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
OC-880
Steps to test or reproduce
Further comments