Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fixed department fowarding not accounting for empty array #29026

Merged
merged 6 commits into from May 2, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Apr 24, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-881
OC-885

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #29026 (df642a9) into release-6.2.0 (2ee3a08) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.2.0   #29026      +/-   ##
=================================================
- Coverage          46.90%   46.74%   -0.16%     
=================================================
  Files                728      728              
  Lines              13862    13862              
  Branches            2194     2194              
=================================================
- Hits                6502     6480      -22     
- Misses              7048     7069      +21     
- Partials             312      313       +1     
Flag Coverage Δ
e2e 46.71% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva changed the title fix: Fixed department fowarding not accounting for empty array regression: Fixed department fowarding not accounting for empty array Apr 24, 2023
@aleksandernsilva aleksandernsilva marked this pull request as ready for review April 24, 2023 19:27
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner April 24, 2023 19:27
KevLehman
KevLehman previously approved these changes Apr 24, 2023
MartinSchoeler
MartinSchoeler previously approved these changes Apr 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 28, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 2, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 2, 2023
@kodiakhq kodiakhq bot merged commit f02ec6e into release-6.2.0 May 2, 2023
37 checks passed
@kodiakhq kodiakhq bot deleted the fix/livechat-switch-departments branch May 2, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants