Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Opening DM through UserCard takes too long. #29190

Merged
merged 3 commits into from May 10, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented May 9, 2023

Proposed changes (including videos or screenshots)

Issue(s)

TC-694

Steps to test or reproduce

  1. Open a channel
  2. Click a username
  3. Click the DM balloon

It should open the DM

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner May 9, 2023 18:38
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.2.0@ced8fcc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0614238 differs from pull request most recent head dc18fdf. Consider uploading reports for the commit dc18fdf to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##             release-6.2.0   #29190   +/-   ##
================================================
  Coverage                 ?   47.05%           
================================================
  Files                    ?      729           
  Lines                    ?    13876           
  Branches                 ?     2196           
================================================
  Hits                     ?     6530           
  Misses                   ?     7031           
  Partials                 ?      315           
Flag Coverage Δ
e2e 47.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh added this to the 6.2.0 milestone May 10, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels May 10, 2023
@ggazzo ggazzo merged commit 64aab51 into release-6.2.0 May 10, 2023
8 of 9 checks passed
@ggazzo ggazzo deleted the fix/openDm branch May 10, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants