Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Fixed all German translation handlebar errors #31139

Merged
merged 5 commits into from
Dec 5, 2023
Merged

i18n: Fixed all German translation handlebar errors #31139

merged 5 commits into from
Dec 5, 2023

Conversation

hardikbhatia777
Copy link
Contributor

Proposed changes (including videos or screenshots)

There are a few incorrect translations in the Deustch (German) i18n files which look like this __Datum__, when they should look like this {{date}}. A similar issue was recently resolved (#30740 ) which occurred due to the same thing.

An example of this (picked from the issue mentioned above):
image

This PR aims to clean up all remaining instances of mistranslated handlebar expressions.

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 2, 2023

⚠️ No Changeset found

Latest commit: 107f076

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #31139 (107f076) into develop (58cbc51) will decrease coverage by 8.43%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31139      +/-   ##
===========================================
- Coverage    57.18%   48.76%   -8.43%     
===========================================
  Files          880     3279    +2399     
  Lines        19925    79997   +60072     
  Branches      3719    16015   +12296     
===========================================
+ Hits         11395    39010   +27615     
- Misses        7841    36407   +28566     
- Partials       689     4580    +3891     
Flag Coverage Δ
e2e 51.44% <ø> (+9.07%) ⬆️
e2e-api 40.80% <ø> (?)
unit 76.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2023
@kodiakhq kodiakhq bot merged commit a7bee82 into RocketChat:develop Dec 5, 2023
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants