Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Displaying wrong composer for archived room #31292

Merged
merged 3 commits into from Dec 26, 2023

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Dec 21, 2023

Proposed changes (including videos or screenshots)

When the public room has joinCode and it is archived, it's displaying the wrong composer, it should show the archived composer instead

Old behavior

image

New behavior

image

Issue(s)

Steps to test or reproduce

Further comments

TC-853

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: 7abc899

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (631f6a4) 59.37% compared to head (7abc899) 49.31%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31292       +/-   ##
============================================
- Coverage    59.37%   49.31%   -10.07%     
============================================
  Files         1782     3301     +1519     
  Lines        34720    81131    +46411     
  Branches      7208    16593     +9385     
============================================
+ Hits         20616    40010    +19394     
- Misses       12529    36462    +23933     
- Partials      1575     4659     +3084     
Flag Coverage Δ
e2e 52.55% <64.70%> (-0.02%) ⬇️
e2e-api 40.63% <ø> (?)
unit 76.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review December 21, 2023 14:37
@dougfabris dougfabris requested a review from a team as a code owner December 21, 2023 14:37
hugocostadev
hugocostadev previously approved these changes Dec 21, 2023
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 26, 2023
@kodiakhq kodiakhq bot merged commit 132853a into develop Dec 26, 2023
44 of 45 checks passed
@kodiakhq kodiakhq bot deleted the fix/archivedRoomComposer branch December 26, 2023 17:08
@scuciatto scuciatto added this to the 6.6 milestone Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants