New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing labels to UsersByTimeOfTheDaySection #31368
Conversation
🦋 Changeset detectedLatest commit: 90074ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31368 +/- ##
===========================================
+ Coverage 49.54% 49.57% +0.03%
===========================================
Files 3304 3314 +10
Lines 81384 81507 +123
Branches 16693 16716 +23
===========================================
+ Hits 40321 40407 +86
- Misses 36375 36396 +21
- Partials 4688 4704 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…/emailEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (166 commits) feat: Add `chat.getURLPreview` endpoint (#30478) chore: QoL changes for Omnichannel (#31468) fix: add missing labels to UsersByTimeOfTheDaySection (#31368) refactor: Remove `Notifications` module (#31463) i18n: zh translation error (#21600) feat: `Bubble` on new messages indicators (#31478) test: fix flaky setGuestName test (#31486) Release 6.5.3 chore: RateLimiter to async (#31480) chore: Revert "chore: Add missing changeset file" (#31481) chore: Remove `MessageContentBody` additional styles (#31476) chore: Replace `Notifications` module in favor of `SDK` inside CachedCollection (#31424) chore: improve backend startup (#31479) chore: fix embedded livechat tests (#31477) fix: Department name being double escaped (#31454) chore: Remove unnecessary changeset file (#31472) chore(eslint-config): Include missing ESLint configuration for React (#30977) refactor: Replace `Notifications` module in favor of `sdk` for Omnichannel/WebRTC (#31460) refactor: Replace `Notifications` module in favor of `sdk` for Video Conf (#31462) feat: Add support to cancel editing message action (#31347) ...
Proposed changes (including videos or screenshots)
In the Engagement Dashboard card
UsersByTimeOfTheDaySection
it was missing the day/time labels in the tooltip and in the bottom axis.Previous:
Now:
Issue(s)
Steps to test or reproduce
Further comments
WM-199