Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ImageGallery zoom controls #31369

Merged
merged 7 commits into from Jan 10, 2024
Merged

feat: add ImageGallery zoom controls #31369

merged 7 commits into from Jan 10, 2024

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Kapture 2024-01-03 at 17 01 29

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 0814d17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5845014) 49.56% compared to head (0814d17) 49.55%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31369      +/-   ##
===========================================
- Coverage    49.56%   49.55%   -0.02%     
===========================================
  Files         3311     3312       +1     
  Lines        81377    81398      +21     
  Branches     16700    16702       +2     
===========================================
+ Hits         40332    40333       +1     
- Misses       36333    36350      +17     
- Partials      4712     4715       +3     
Flag Coverage Δ
e2e 53.10% <0.00%> (-0.01%) ⬇️
e2e-api 40.68% <ø> (-0.02%) ⬇️
unit 76.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti added this to the 6.6 milestone Jan 4, 2024
@juliajforesti juliajforesti marked this pull request as ready for review January 5, 2024 17:24
@juliajforesti juliajforesti requested a review from a team as a code owner January 5, 2024 17:24
tassoevan
tassoevan previously approved these changes Jan 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 10, 2024
@kodiakhq kodiakhq bot merged commit 8c69edd into develop Jan 10, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the feat/gallery-zoom branch January 10, 2024 17:02
gabriellsh added a commit that referenced this pull request Jan 10, 2024
…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(i18n): Translation's lint and load (#31343)
  fix: multiple indexes creations during migrations (#31413)
  feat: add `ImageGallery` zoom controls (#31369)
  chore: internalize flow-router (from meteor 3 branch) (#31365)
  chore: internalize meteor run as user (from meteor 3) (#31370)
  chore: internalize meteor inject initial (from meteor 3) (#31367)
  chore: internalize meteor cookies (from meteor 3) (#31366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants