New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update SHIFT+ESCAPE handler for consistent clear unread modal display #31432
Conversation
🦋 Changeset detectedLatest commit: 22ce63a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31432 +/- ##
========================================
Coverage 49.56% 49.57%
========================================
Files 3313 3316 +3
Lines 81477 81514 +37
Branches 16709 16716 +7
========================================
+ Hits 40386 40411 +25
- Misses 36393 36398 +5
- Partials 4698 4705 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Congratulations on your first PR as a rocketeer. 🚀
Proposed changes (including videos or screenshots)
This PR addresses the issue with the SHIFT+ESCAPE shortcut in Rocket.Chat. The shortcut was not consistently triggering the unread messages clearing modal. The fix ensures consistent functionality across different states of unread messages and browsers.
Issue(s)
SHIFT+ESCAPE not always clears all unread messages and loading task manager instead
Steps to test or reproduce
Further comments
SUP-222