Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update SHIFT+ESCAPE handler for consistent clear unread modal display #31432

Merged
merged 3 commits into from Jan 16, 2024

Conversation

abhinavkrin
Copy link
Member

Proposed changes (including videos or screenshots)

This PR addresses the issue with the SHIFT+ESCAPE shortcut in Rocket.Chat. The shortcut was not consistently triggering the unread messages clearing modal. The fix ensures consistent functionality across different states of unread messages and browsers.

Issue(s)

SHIFT+ESCAPE not always clears all unread messages and loading task manager instead

Steps to test or reproduce

  1. Ensure that there is at least one unread message.
  2. Verify that the Rocket.Chat tab is currently focused in the browser.
  3. Press SHIFT+ESCAPE and observe if the unread messages clearing modal appears.
  4. Test across multiple browsers (Chrome, Firefox, Edge) and scenarios (e.g., after a reload, when new messages arrive).

Further comments

SUP-222

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 22ce63a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (224e194) 49.56% compared to head (22ce63a) 49.57%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31432   +/-   ##
========================================
  Coverage    49.56%   49.57%           
========================================
  Files         3313     3316    +3     
  Lines        81477    81514   +37     
  Branches     16709    16716    +7     
========================================
+ Hits         40386    40411   +25     
- Misses       36393    36398    +5     
- Partials      4698     4705    +7     
Flag Coverage Δ
e2e 53.16% <100.00%> (+<0.01%) ⬆️
e2e-api 40.69% <ø> (+0.01%) ⬆️
unit 76.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin marked this pull request as ready for review January 12, 2024 16:38
@abhinavkrin abhinavkrin requested a review from a team as a code owner January 12, 2024 16:38
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Congratulations on your first PR as a rocketeer. 🚀

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 16, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 16, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 16, 2024
@kodiakhq kodiakhq bot merged commit 54bdda3 into develop Jan 16, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the fix/shift-escape-unread-clearing branch January 16, 2024 17:46
@scuciatto scuciatto added this to the 6.6 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants