fix: breaks the avatar if you hit the button adding an invalid link #31467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 552a1e4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31467 +/- ##
============================================
+ Coverage 49.57% 76.47% +26.90%
============================================
Files 3316 278 -3038
Lines 81517 9008 -72509
Branches 16719 1708 -15011
============================================
- Hits 40411 6889 -33522
+ Misses 36400 1688 -34712
+ Partials 4706 431 -4275
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
previously requested changes
Jan 26, 2024
ggazzo
dismissed
their stale review
My mistake, the changesetbot was crazy :s
dougfabris
approved these changes
Jan 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Before:
screen-capture.webm
After:
Changes I made:
The input field for the URL will only accept an image URL, any other non-image URL or invalid URL will not be accepted.
Issue(s)
Closes #21024
Steps to test or reproduce
Further comments