Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Engagement dashboard crashing #31591

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jan 31, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

TC-1094

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 65f8019

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review January 31, 2024 15:29
@casalsgh casalsgh requested a review from a team January 31, 2024 15:34
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be good to revisit this problem in the future and see which specific part of the new useEndpointAction hook caused this but since this is only happening in the engagement dashboard, we are close to release and useEndpoint fits better in this place I'll approve it.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2378f68) 76.47% compared to head (65f8019) 45.37%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.6.0   #31591       +/-   ##
==================================================
- Coverage          76.47%   45.37%   -31.11%     
==================================================
  Files                278     3220     +2942     
  Lines               9008    75665    +66657     
  Branches            1708    15510    +13802     
==================================================
+ Hits                6889    34334    +27445     
- Misses              1688    36863    +35175     
- Partials             431     4468     +4037     
Flag Coverage Δ
e2e 53.24% <ø> (∅)
e2e-api 40.63% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 31, 2024
@kodiakhq kodiakhq bot merged commit 53b934e into release-6.6.0 Jan 31, 2024
49 of 50 checks passed
@kodiakhq kodiakhq bot deleted the reg/engagement-dashboard branch January 31, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants