Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Opening WrapUpCallModal crashes the GUI #31620

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Feb 2, 2024

Proposed changes (including videos or screenshots)

Issue(s)

OC-1451

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 18cc7d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b32093f) 54.38% compared to head (18cc7d0) 54.45%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.6.0   #31620      +/-   ##
=================================================
+ Coverage          54.38%   54.45%   +0.06%     
=================================================
  Files               2270     2273       +3     
  Lines              49992    50009      +17     
  Branches           10241    10212      -29     
=================================================
+ Hits               27187    27230      +43     
+ Misses             20364    20304      -60     
- Partials            2441     2475      +34     
Flag Coverage Δ
e2e 53.32% <ø> (+0.08%) ⬆️
e2e-api 39.94% <ø> (+0.06%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review February 5, 2024 13:56
@aleksandernsilva aleksandernsilva added this to the 6.6 milestone Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 5, 2024
@kodiakhq kodiakhq bot merged commit 0032878 into release-6.6.0 Feb 5, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the regression/wrap-up-call-gui-crash branch February 5, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants