fix: Jump to message only works once

[SySagar]

fix: dynamic slug during search
feat: patch update

• I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
• I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Updated the slug update logic in the setMessageJumpQueryStringParameter module. Now works good.

Issue(s)

closes #31653
CORE-56
#31727

Steps to test or reproduce

• Steps to reproduce:
• Go to search box on top left.
• Search any item
• Click on jump to that message button
• Then search something else

[changeset-bot]

🦋 Changeset detected

Latest commit: d10e188

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gabriellsh]

Hey, thanks for the contribution!

I'll rename this PR to a more appropriate name.
I understand the reasoning behind what you did to fix the issue, but I think we can do one better. If you reset the setMessageJumQueryStringParameter.ts file, you can do the following:

const locationPathname = new URL(window.location.href).pathname as LocationPathname

This will have pretty much the same effect, but will be significantly easier to read, and will also prevent us from duplicating other query string parameters.

[SySagar]

@gabriellsh I have updated your changes. Please review.

[SySagar]

ok then I am reseting back all my commits and updating the changes. I guess this will be ok @gabriellsh

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.62%. Comparing base (85fe51a) to head (d10e188).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31662      +/-   ##
===========================================
+ Coverage    54.58%   54.62%   +0.03%     
===========================================
  Files         2280     2283       +3     
  Lines        50262    50281      +19     
  Branches     10254    10255       +1     
===========================================
+ Hits         27436    27465      +29     
+ Misses       20337    20325      -12     
- Partials      2489     2491       +2     

Flag	Coverage Δ
e2e	53.63% <0.00%> (+0.05%)	⬆️
e2e-api	40.02% <ø> (+0.01%)	⬆️
unit	76.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[SySagar]

hey @gabriellsh . I am not sure whether it will be merged or not? what would your recommend me to do?

[SySagar]

any update for this pr @gabriellsh @dougfabris ?

[yash-rajpal]

@SySagar Can you please address the lint issues?

[SySagar]

hey @gabriellsh @dougfabris I have fixed the linting issue. Can you now merge it please?

[yash-rajpal]

LGTM

[SySagar]

hey @yash-rajpal , seems there were some more lint issue. I fixed them up.

[SySagar]

hey @ggazzo can you please approve this

stale