Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setDepartment Livechat API call overriding triggers #31663

Merged
merged 5 commits into from Mar 13, 2024

Conversation

MartinSchoeler
Copy link
Contributor

CORE-50

REQUIRES #31268

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: 9bcafd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/livechat Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 6.7 milestone Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.50%. Comparing base (fe1f6ce) to head (9bcafd2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31663      +/-   ##
===========================================
- Coverage    54.54%   54.50%   -0.05%     
===========================================
  Files         2293     2294       +1     
  Lines        50526    50557      +31     
  Branches     10318    10324       +6     
===========================================
- Hits         27560    27555       -5     
- Misses       20472    20502      +30     
- Partials      2494     2500       +6     
Flag Coverage Δ
e2e 53.52% <ø> (-0.06%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler changed the base branch from develop to feat/triggers-omni March 5, 2024 13:13
@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 5, 2024 13:15
@MartinSchoeler MartinSchoeler requested review from a team as code owners March 5, 2024 13:15
Base automatically changed from feat/triggers-omni to develop March 12, 2024 19:06
@kodiakhq kodiakhq bot requested a review from a team as a code owner March 12, 2024 19:06
@MartinSchoeler MartinSchoeler force-pushed the fix-livechat-department-trigger branch from 7aaad54 to 552c3c9 Compare March 12, 2024 20:39
.changeset/afraid-mugs-priest.md Outdated Show resolved Hide resolved
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 13, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2024
@kodiakhq kodiakhq bot merged commit b9ef630 into develop Mar 13, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the fix-livechat-department-trigger branch March 13, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants