New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct display of discussion names in sidebar search #31701
Conversation
🦋 Changeset detectedLatest commit: 832cdf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31701 +/- ##
===========================================
- Coverage 54.52% 54.48% -0.05%
===========================================
Files 2272 2271 -1
Lines 50103 50089 -14
Branches 10219 10219
===========================================
- Hits 27321 27289 -32
- Misses 20309 20327 +18
Partials 2473 2473
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case to cover this scenario?
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Hey @MarcosSpessatto I have added test for this scenario. It tests discussion search in both cases when |
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
…search-discussion-name-handling
…LinkAction * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) fix: Login page breaking when handling not expected errors (#31804) chore: Upgrade `react-virtuoso` (#31843) chore: Refactor & Improve Livechat Widget API (#30924) i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855) i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856) chore: Sidebar toolbar keyboard navigation (#31846) fix(eslint-config): react config file export (#31845) chore: cache ui-context package (#31805) fix: make lifecycle methods part of inherited class in federation services (#31844) fix: client ignoring offline presence updates (#31833) test: saml login custom role (#31830) chore: `VideoConfPopup` keyboard navigability (#31831) fix: revert status websocket payload changes (#31823) chore: `UserCard` focus improvements (#31812) regression: Prevent storing lastFocused message by click event (#31819) chor: allow offline development build test: make calendar api tests fully independent (#31785) fix: Correct display of discussion names in sidebar search (#31701) bump meteor 2.15 (#31799) test: make apps api tests fully independent (#31787) ...
Proposed changes (including videos or screenshots)
This fix alters the spotlight search endpoint method to include the
prid
(parent room ID) for rooms. This adjustment ensures that the client correctly identifies discussions and displays their names instead of IDs in the sidebar search results. This change resolves the issue where discussion IDs were displayed when the "Allow Special Characters in Room Names" setting was disabled, aligning the behavior with the search results when the setting is enabled.Issue(s)
Fixes issue where discussion names were incorrectly displayed as IDs in sidebar search results under specific conditions.
Steps to test or reproduce
Further comments
SUP-410