Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reactions tooltip loader #31703

Merged
merged 3 commits into from Feb 9, 2024
Merged

Conversation

yash-rajpal
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-57

Copy link

changeset-bot bot commented Feb 9, 2024

🦋 Changeset detected

Latest commit: 7cdca76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review February 9, 2024 01:17
@yash-rajpal yash-rajpal requested a review from a team as a code owner February 9, 2024 01:17
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1e833d5) 54.35% compared to head (7cdca76) 54.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31703      +/-   ##
===========================================
- Coverage    54.35%   54.33%   -0.03%     
===========================================
  Files         2276     2271       -5     
  Lines        50120    50044      -76     
  Branches     10217    10207      -10     
===========================================
- Hits         27245    27191      -54     
+ Misses       20389    20370      -19     
+ Partials      2486     2483       -3     
Flag Coverage Δ
e2e 53.15% <0.00%> (-0.05%) ⬇️
e2e-api 39.87% <ø> (ø)
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal added this to the 6.7 milestone Feb 9, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 9, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 9, 2024
@kodiakhq kodiakhq bot merged commit 0639794 into develop Feb 9, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the fix/reactions-tooltip-loader branch February 9, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants