New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DM notifications when preference set to mentions #31759
Conversation
🦋 Changeset detectedLatest commit: c8c3d2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31759 +/- ##
===========================================
- Coverage 54.53% 54.49% -0.04%
===========================================
Files 2274 2268 -6
Lines 50107 50054 -53
Branches 10220 10212 -8
===========================================
- Hits 27324 27278 -46
+ Misses 20310 20304 -6
+ Partials 2473 2472 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
b4b744e
to
d22ea02
Compare
d22ea02
to
cf5f5db
Compare
Proposed changes (including videos or screenshots)
If the notification preference was set to mentions at any level (server, user or room level), messages sent in DMs were not triggering a notification. But since we consider DMs as "mentions", this behavior was not correct. This PR makes this behavior consistent across all levels of notification preferences, whenever "mentions" is selected, messages on DMs will trigger a notification.
Issue(s)
Steps to test or reproduce
Further comments