Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DM notifications when preference set to mentions #31759

Merged
merged 3 commits into from Feb 21, 2024

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Feb 14, 2024

Proposed changes (including videos or screenshots)

If the notification preference was set to mentions at any level (server, user or room level), messages sent in DMs were not triggering a notification. But since we consider DMs as "mentions", this behavior was not correct. This PR makes this behavior consistent across all levels of notification preferences, whenever "mentions" is selected, messages on DMs will trigger a notification.

Issue(s)

Steps to test or reproduce

  • Go to "User Preferences > Notifications > Show Desktop Notifications For" and select "Mentions"
  • Ask someone to send a message in a DM
  • A desktop notification should be triggered

Further comments

Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: c8c3d2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ff4110) 54.53% compared to head (c8c3d2a) 54.49%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31759      +/-   ##
===========================================
- Coverage    54.53%   54.49%   -0.04%     
===========================================
  Files         2274     2268       -6     
  Lines        50107    50054      -53     
  Branches     10220    10212       -8     
===========================================
- Hits         27324    27278      -46     
+ Misses       20310    20304       -6     
+ Partials      2473     2472       -1     
Flag Coverage Δ
e2e 53.39% <ø> (-0.07%) ⬇️
e2e-api 39.94% <ø> (ø)
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego force-pushed the fix-dm-notifications-for-mentions branch from b4b744e to d22ea02 Compare February 15, 2024 13:38
@sampaiodiego sampaiodiego force-pushed the fix-dm-notifications-for-mentions branch from d22ea02 to cf5f5db Compare February 20, 2024 21:43
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 21, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 21, 2024
@kodiakhq kodiakhq bot merged commit c18f3e3 into develop Feb 21, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the fix-dm-notifications-for-mentions branch February 21, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants