Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tag to premium settings in CE workspaces #32038

Merged
merged 6 commits into from Mar 22, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Mar 20, 2024

Proposed changes (including videos or screenshots)

A premium tag will be displayed alongside the setting label for premium exclusive settings in CE workspaces.
This will bring visibility for users of our premium features while also informing them of the reason why the setting is currently disabled.

Screen Shot 2024-03-20 at 14 26 57

Issue(s)

PROSVC-48

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 7cdec53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 53.99%. Comparing base (258c502) to head (7cdec53).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32038      +/-   ##
===========================================
- Coverage    54.70%   53.99%   -0.72%     
===========================================
  Files         2298     2221      -77     
  Lines        50703    49608    -1095     
  Branches     10352    10134     -218     
===========================================
- Hits         27739    26785     -954     
+ Misses       20468    20394      -74     
+ Partials      2496     2429      -67     
Flag Coverage Δ
e2e 52.37% <57.14%> (-1.38%) ⬇️
e2e-api 40.06% <ø> (+<0.01%) ⬆️
unit 75.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 20, 2024 19:02
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner March 20, 2024 19:02
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the specific Settings types shares the same properties, couldn't you create a Common type and just extend it when necessary?

Congrats man! 🚀

apps/meteor/client/views/admin/settings/Setting.tsx Outdated Show resolved Hide resolved
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 22, 2024
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @aleksandernsilva ! 🚀
approved

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 22, 2024
@kodiakhq kodiakhq bot merged commit b33e5a9 into develop Mar 22, 2024
44 of 45 checks passed
@kodiakhq kodiakhq bot deleted the feat/setting-premium-tag branch March 22, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants