New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added tag to premium settings in CE workspaces #32038
Conversation
🦋 Changeset detectedLatest commit: 7cdec53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32038 +/- ##
===========================================
- Coverage 54.70% 53.99% -0.72%
===========================================
Files 2298 2221 -77
Lines 50703 49608 -1095
Branches 10352 10134 -218
===========================================
- Hits 27739 26785 -954
+ Misses 20468 20394 -74
+ Partials 2496 2429 -67
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the specific Settings types shares the same properties, couldn't you create a Common type and just extend it when necessary?
Congrats man! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @aleksandernsilva ! 🚀
Proposed changes (including videos or screenshots)
A premium tag will be displayed alongside the setting label for premium exclusive settings in CE workspaces.
This will bring visibility for users of our premium features while also informing them of the reason why the setting is currently disabled.
Issue(s)
PROSVC-48
Steps to test or reproduce
Further comments