Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rooms.export endpoint generates empty export when given an invalid date #32046

Closed
wants to merge 43 commits into from

Conversation

matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Mar 21, 2024

Proposed changes (including videos or screenshots)

  • Use oldest possible date as dateFrom when this param is not provided to the rooms.export endpoint;
  • Use current date as dateTo when this param is not provided to the rooms.export endpoint;
  • Added end-to-end tests for the export rooms as file feature.

Issue(s)

Steps to test or reproduce

Further comments

SUP-523

Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: 83b6db2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/rest-typings Major
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.08%. Comparing base (972b5b8) to head (83b6db2).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #32046       +/-   ##
============================================
+ Coverage    55.57%   73.08%   +17.50%     
============================================
  Files         2403      354     -2049     
  Lines        52841    11133    -41708     
  Branches     10851     2135     -8716     
============================================
- Hits         29366     8136    -21230     
+ Misses       20876     2427    -18449     
+ Partials      2599      570     -2029     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 73.08% <37.50%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review March 21, 2024 16:22
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners March 21, 2024 16:22
@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Mar 21, 2024
abhinavkrin
abhinavkrin previously approved these changes Mar 21, 2024
Copy link
Member

@abhinavkrin abhinavkrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jessicaschelly
jessicaschelly previously approved these changes Mar 27, 2024
Copy link
Member

@jessicaschelly jessicaschelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

Copy link
Contributor

dionisio-bot bot commented Apr 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.9.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@matheusbsilva137 matheusbsilva137 changed the title fix: rooms.export endpoint generates empty export when given an invalid date fix!: rooms.export endpoint generates empty export when given an invalid date Apr 9, 2024
@matheusbsilva137 matheusbsilva137 changed the base branch from develop to release-7.0.0 April 9, 2024 19:29
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 321fc95 to 442e2a9 Compare April 11, 2024 19:55
@matheusbsilva137
Copy link
Contributor Author

Closing this in favor of #32364 (rebasing this to include it in 6.9, this PR is kinda messed up for me to rebase it again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: core stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants