fix: "Forgot Password" e-mail is not translated correctly #32212
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Diego Sampaio <chinello@gmail.com>
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6a6fbfd The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32212 +/- ##
=================================================
- Coverage 55.56% 55.54% -0.02%
=================================================
Files 2408 2410 +2
Lines 53019 53074 +55
Branches 10902 10909 +7
=================================================
+ Hits 29460 29480 +20
- Misses 20941 20970 +29
- Partials 2618 2624 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
previously approved these changes
Apr 15, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
matheusbsilva137
dismissed
gabriellsh’s stale review
The base branch was changed.
dionisio-bot
bot
removed
the
stat: ready to merge
Co-authored-by: Diego Sampaio <chinello@gmail.com>
ggazzo
force-pushed
the
release-7.0.0
branch
2 times, most recently
from
472825d
to
68fee68
Compare
ggazzo
force-pushed
the
release-7.0.0
branch
2 times, most recently
from
495a17e
to
a3e9e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Forgot_Password_Emailsetting.Issue(s)
Introduced by #31343
Steps to test or reproduce
Start a workspace on 6.5 (or an older version), then update to the latest RC version. Then, check the e-mail received when triggering the "forgot password" flow.
Current behavior: the e-mail contains the text
Lets_get_you_new_one(not correctly translated key).Expected behavior: the e-mail should contain a translated text (such as "Let's get you a new one!") instead of a key.
Further comments
CORE-247