Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ReadReceiptIndicator a11y improvement #32317

Merged
merged 13 commits into from May 16, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 25, 2024

Proposed changes (including videos or screenshots)

Once a message is read (read-receipts feature), it should display the blue check-double icon instead of the check icon, in order to improve accessibility

before

after

Issue(s)

Steps to test or reproduce

Further comments

CORE-308

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 9b92de9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Apr 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris added this to the 6.9 milestone Apr 25, 2024
@dougfabris dougfabris marked this pull request as ready for review April 25, 2024 23:50
@dougfabris dougfabris requested review from a team as code owners April 25, 2024 23:50
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.58%. Comparing base (fb6d9eb) to head (9b92de9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32317      +/-   ##
===========================================
- Coverage    55.70%   55.58%   -0.12%     
===========================================
  Files         2406     2410       +4     
  Lines        53097    53100       +3     
  Branches     10918    10919       +1     
===========================================
- Hits         29576    29517      -59     
- Misses       20907    20965      +58     
- Partials      2614     2618       +4     
Flag Coverage Δ
e2e 55.12% <88.88%> (+0.14%) ⬆️
unit 72.74% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding here for historical proposes. This proposal will have another improvements regarding the readiness of the check/double check state... waiting for that!

tiagoevanp
tiagoevanp previously approved these changes Apr 27, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2024
Copy link
Contributor

kodiakhq bot commented May 2, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label May 2, 2024
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label May 16, 2024
@kodiakhq kodiakhq bot merged commit b01cdce into develop May 16, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the feat/readReceiptsIndicator branch May 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants